Updated the examples repo to build with the re-export messages changes#19
Open
maspe36 wants to merge 1 commit intoros2-rust:mainfrom
Open
Updated the examples repo to build with the re-export messages changes#19maspe36 wants to merge 1 commit intoros2-rust:mainfrom
maspe36 wants to merge 1 commit intoros2-rust:mainfrom
Conversation
esteve
reviewed
Feb 17, 2026
| @@ -29,7 +29,6 @@ path = "src/zero_copy_publisher.rs" | |||
| anyhow = {version = "1", features = ["backtrace"]} | |||
| rclrs = "0.6" | |||
| rosidl_runtime_rs = "0.5" | |||
Contributor
There was a problem hiding this comment.
@maspe36 wouldn't this conflict with the currently released version of rosidl_runtime_rs (0.6)? I think it'd be good to reexport rosidl_runtime_rs from rclrs and remove this dependency so that if any downstream dependency requires access to rosidl_runtime_rs, it matches the one that rclrs depends on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.